Fix/windows key release input#5
Open
1553620375 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix duplicate TUI input on Windows by filtering key release events at the terminal event
boundary.
On Windows, crossterm reports key press and key release as separate keyboard events. The TUI
adapter previously dropped
KeyEventKind, so both press and release were converted into thesame internal key event. This caused typed characters to appear twice, and Backspace/Delete
to delete twice.
This change adds a centralized crossterm-to-TUI conversion path that ignores
KeyEventKind::Releasebefore events reach UI models.PressandRepeatevents are stillpreserved, so normal input and held-key repeat behavior continue to work.
Changes
Event::from_crossterm(...) -> Option<Event>for crossterm event conversion.KeyEventKind::Releaseat the event boundary.ProgramandElementProgramevent loops to use the filtered conversion path.Verification
Ran from
TUI: